URL.host should not return percent-encoded host #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
No, thank you @jrflat! 🎉 |
jrflat
force-pushed
the
url-host-no-encoding
branch
from
fb88623 to
da61158
Compare
|
Fixed conflicts |
|
@swift-ci please test |
parkera
approved these changes
Aug 21, 2024
jmschonfeld
approved these changes
Aug 21, 2024
This was referenced Sep 23, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
URL.hostwould just call.host(), which defaults to.host(percentEncoded: true). This meant that if the host was IDNA-encoded,.hostwould decode the IDNA-encoding and then percent-encode, returning the percent-encoded string.This PR fixes
.hostto match the behavior before the Swift URL implementation:This is exactly the behavior of
.host(percentEncoded: false), which is now used instead of.host().Resolves #863 (thanks @Lukasa!)